Re: [PATCH] pinctrl: sh-pfc: r8a7795: Add SATA pins, groups, and functions

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

On Wed, Dec 20, 2017 at 10:59 PM, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Tested with a Salvator-XS and H3 ES2.0.

Thanks for your patch!

> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in sh-pfc-for-v4.16.

> Note: To repeat the test you must:
> a) switch pin7 from SW12 to OFF

Funny how the relation of MD12 to SATA is mentioned only in the Salvator-XS
hardware manual, but not in the R-Car Gen3 User's Manual? Or did I miss it?

> b) set an external GPIO to 0 by using these commands:
>         i2cset -y 4 0x20 3 0x7f (set pin to output)
>         i2cset -y 4 0x20 1 0x7f (set pin to 0)

Time to add the PCA9654 to the DTS, so users can use a gpio-hog instead?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html