Re: [PATCH] pinctrl: single: Remove invalid message

[Tony Lindgren <tony@xxxxxxxxxxx>]

* Haojian Zhuang <haojian.zhuang@xxxxxxxxxx> [171217 05:43]:
> On 2017/12/15 0:51, Tony Lindgren wrote:
> > Pinctrl single should just show how many pins were found, the physical
> > address is already in the dev information. So let's remove the wrong
> > information that claims to show the physical address but really prints
> > a virtual address that is now hashed.
> > 
> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > ---
> >   drivers/pinctrl/pinctrl-single.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
> > --- a/drivers/pinctrl/pinctrl-single.c
> > +++ b/drivers/pinctrl/pinctrl-single.c
> > @@ -1774,8 +1774,7 @@ static int pcs_probe(struct platform_device *pdev)
> >   			dev_warn(pcs->dev, "initialized with no interrupts\n");
> >   	}
> > -	dev_info(pcs->dev, "%i pins at pa %p size %u\n",
> > -		 pcs->desc.npins, pcs->base, pcs->size);
> > +	dev_info(pcs->dev, "%i pins, size %u\n", pcs->desc.npins, pcs->size);
> >   	return pinctrl_enable(pcs->pctl);
> > 
> Hi Tony,
> 
> If there's only one pinctrl region in SoC, it's fine to remove the pa part.
> But there're always multiple pinctrl regions in Hisilicon SoCs. It causes
> multiple pinctrl register bases are used. Will it cause debug information
> harder to read when pa parts are removed?

I doubt as for years now we've been printing out the va instead of pa
and so far nobody noticed :) We still get the real device pa with the
dev_info, size and number of pins.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html