Re: [PATCH] pinctrl: sh-pfc: r8a7795: Add GP-1-28 port pin support

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Kaneko-san,

On Thu, Nov 23, 2017 at 11:03 AM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Nov 16, 2017 at 4:14 AM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
>> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>>
>> This patch supports GP-1-28 port pin of R8A7795 ES2.0 SoC added in
>> Rev.0.54E of the R-Car Gen3 Hardware User's Manual or later version.
>>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
>
> Thanks for your patch!
>
>> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
>> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
>
>> @@ -5246,7 +5248,7 @@ enum {
>>                 { RCAR_GP_PIN(1, 19),  0, 3 },  /* A19 */
>>         } },
>>         { PINMUX_DRIVE_REG("DRVCTRL8", 0xe6060320) {
>> -               { PIN_NUMBER('F', 1), 28, 3 },  /* CLKOUT */
>> +               { RCAR_GP_PIN(1, 28), 28, 3 },  /* CLKOUT */
>>                 { RCAR_GP_PIN(1, 20), 24, 3 },  /* CS0 */
>>                 { RCAR_GP_PIN(1, 21), 20, 3 },  /* CS1_A26 */
>>                 { RCAR_GP_PIN(1, 22), 16, 3 },  /* BS */
>
> You should make a similar change to the corresponding entry for "PUEN2",
> cfr. drivers/pinctrl/sh-pfc/pfc-r8a7796.c.
>
> With that fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Nevermind, I fixed that up myself while applying.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html