Really, the of_node_put() is connected to the loop and not the function so the original code is the right way to do it. Otherwise if we added more error handling to the function then normal kernel error handling wouldn't work naturally. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to_map()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to_map()
- From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
- Date: Wed, 1 Nov 2017 13:33:35 +0300
- In-reply-to: <CAMuHMdXSVXZNW7a-xf_zyCW-j_KVQbRBdrt8q-SNjGChuDU-bw@mail.gmail.com>
- References: <80911d4b-d819-335c-106e-70d7672e645b@users.sourceforge.net> <CAMuHMdXSVXZNW7a-xf_zyCW-j_KVQbRBdrt8q-SNjGChuDU-bw@mail.gmail.com>
- User-agent: NeoMutt/20170609 (1.8.3)
- References:
- [PATCH] pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to_map()
- From: SF Markus Elfring
- Re: [PATCH] pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to_map()
- From: Geert Uytterhoeven
- [PATCH] pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to_map()
- Prev by Date: Re: [PATCH] pinctrl: pistachio: Use common error handling code in pistachio_gpio_register()
- Next by Date: Re: [PATCH v5 00/13] gpio: Tight IRQ chip integration
- Previous by thread: Re: pinctrl: sirf: Use common error handling code in sirfsoc_dt_node_to_map()
- Next by thread: [PATCH 0/4] [v6] pinctrl: qcom: add support for sparse GPIOs
- Index(es):
 |