Re: [PATCH] gpio: brcmstb: Do not use gc->pin2mask()

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Oct 20, 2017 at 5:51 PM, Gregory Fong <gregory.0xf0@xxxxxxxxx> wrote:
> Hi Linus,
>
> On Fri, Oct 20, 2017 at 6:48 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> The pin2mask() accessor only shuffles BIT ORDER in big endian systems,
>> i.e. the bitstuffing is swizzled big endian so "bit 0" is bit 7 or
>> bit 15 or bit 31 or so.
>>
>> The brcmstb only uses big endian BYTE ORDER which will be taken car of
>> by the ->write_reg() callback.
>>
>> Just use BIT(offset) to assign the bit.
>
> I believe the patches that Doug is putting together already take care
> of this, would you be OK with it being handled in there instead?

I would prefer that those changes base on top of this instead.

I need to get rid of ->pin2mask() for other GPIO improvements in
the core, like supporting .get_multiple() in gpio-mmio.

I can apply this to the devel branch per immediately so Doug can base
his work on top of it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html