On Sat, Sep 30, 2017 at 5:07 PM, Heiko Stuebner <heiko@xxxxxxxxx> wrote: > Am Samstag, 30. September 2017, 20:13:21 CEST schrieb David Wu: >> If the gmac-m1 optimization(bit10) is selected, the gpio function >> of gmac pins is not valid. We may use the rmii mode for gmac interface, >> the pins such as rx_d2, rx_d3, which the rgmii mode used, but rmii not >> used could be taken as gpio function. So gmac_rxd0m1 selects the bit2, >> and gmac_rxd0m3 select bit10 is more correct. >> >> Signed-off-by: David Wu <david.wu@xxxxxxxxxxxxxx> > > the patch subject should mention the the rk3328 whose routing gets fixed > (like adding a simple "on rk3328" to it), otherwise > > Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> I added rk3328 to it, also assumed this Reviewed-by covers patch 1/2 as well and applied both with your tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html