RE: [PATCH 1/2] pinctrl: rza1: add support for RZ/A1L

[Chris Brandt <Chris.Brandt@xxxxxxxxxxx>]

Hi Jacopo,

On Tuesday, October 03, 2017 1, jacopo mondi wrote:
> > As for SSI, the manual says only the SSITx pins need bi-dir, not the
> > SSIRx pins.
> 
> Looking at RZ/A1H tables you're right. I wonder why in RZ/A1L SSI pins
> are listed as bidir and in RZ/A1H they're not.

Sorry, to be clear, SSITx pins have nothing to do with "bi-dir".

Those were pins that you have to add to the rza1l_swio_pins[] array 
because they must have to have both PIPCn.PIPC and PM bits set to '0' (ie, 
forced to output).

However, there is no SSITxD5 pin in RZ/A1L.

  RZ/A1H: SSITxD0, SSITxD1, SSITxD3, SSITxD5
  RZ/A1L: SSITxD0, SSITxD1, SSITxD3



> > I thought we said TIOC didn't need to be in a table because the user has
> > to specify them anyway because the user has to choose if he wants them
> > as input or output, so if he does that, then we automatically know it's
> > a swio pin. Hmm, maybe I have to go back and look at what the driver
> > ended up implementing.
> >
> 
> Can confirm TIOC pins are not listed in SWIO table in RZ/A1H.

Yes, that 'are' listed in the table. But for a good reason.

The TIOC pins can be uses as an output (PWM for example) or as a input 
(input capture for example), so they are not really a fixed direction. 
That is why the user needs to specify how they plan to use them in the DT.
And...that's also why it doesn't make sense to put them in the 
rza1l_swio_pins[] array (we have no idea how they want to use them).

So, the hardware manual has the TIOC pins in the SWIO table to tell the 
user 'hey, you have to manually set these pins to either input or output
yourself because we can't magically know what you want to use them for.

But...
The reason for the rza1l_swio_pins[] array is for weird pin 
configurations that are fixed (like LCD LVDS output pins need to be configured as 
inputs).


> Thanks for double checking. Your source from Japan is more
> authoritative than manuals and defintely more accurate than me ;)

So, after all that, I don't think we found any issues with my patch.
Correct???


Thanks!

Chris

��.n��������+%������w��{.n�����{��
b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f