RE: [PATCH 1/2] pinctrl: rza1: add support for RZ/A1L

[Chris Brandt <Chris.Brandt@xxxxxxxxxxx>]

Hi Jacopo,

On Tuesday, October 03, 2017, jacopo mondi wrote:
> Do you have other authoritative sources for pin's bidir settings?
> According to the publicly available manual, there are other pins that
> needs bidir not listed here.
> As the same happened with RZ/A1H I'm not too concerned, but I'm
> listing some of there here nonetheless

Back when you were working on this, I discussed with the guys back in 
Japan. While in the table there are multiple pins that show 
'bi-directional capable', they don't all need the bi-dir bit set. This was the list of
peripheral:
 I2C, MDIO (ETH), MMC, SDHI, QSPI, Data (D0-D31)


> P2 has several TIOC pins in mode 4 and SSI in mode 2

Port 2???
Port 2, mode 4 in the RZ/A1L manual only has IRQ7,6,5,2,1


I thought we decided on that TIOC pins are ones that are manually set to
either input (input-enable, output-enable) by the users Device Tree, so
they don't need to be put into a table. If input-enable or 
output-enable is specified, then you manually set it to that direction.

As for SSI, the manual says only the SSITx pins need bi-dir, not the 
SSIRx pins.


> TIOC in mode3, SKC3 and SCK1 in mode 5
> > +
> > +static const struct rza1_bidir_pin rza1l_bidir_pins_p4[] = {
> > +	{ .pin = 1, .func = 4 },
> > +	{ .pin = 2, .func = 2 },
> > +	{ .pin = 3, .func = 2 },
> > +	{ .pin = 6, .func = 2 },
> > +	{ .pin = 7, .func = 2 },
> > +};
> 
> Confused, you're here listing TIOC2B pin (pin 1 mode #4) but not TIOC1B
> (pin 0 mode #4)
> ET_MDIO in mode 4, which we list as bidir in RZ/A1H

P4_1 mode 4 is ET_MDIO.

TIOC1B is P4_0 mode 3.
TIOC2B is P4_1 Mode 3

Are you looking at Table 41.19 in the Rev.3.00 version of the RZ/A1L 
Hardware Manual?

> > +static const struct rza1_swio_pin rza1l_swio_pins[] = {
> > +	{ .port = 2, .pin = 8, .func = 2, .input = 0 },
> > +	{ .port = 5, .pin = 6, .func = 3, .input = 0 },
> > +	{ .port = 6, .pin = 6, .func = 3, .input = 0 },
> > +	{ .port = 6, .pin = 10, .func = 3, .input = 0 },
> > +	{ .port = 7, .pin = 10, .func = 2, .input = 0 },
> > +	{ .port = 8, .pin = 2, .func = 3, .input = 0 },
> > +};
> 
> I count 20 SWIO pins
> 
> TIOC[0-4][A-D]
> SSITx[0-3]
> WDTOVF

I thought we said TIOC didn't need to be in a table because the user has
to specify them anyway because the user has to choose if he wants them 
as input or output, so if he does that, then we automatically know it's 
a swio pin. Hmm, maybe I have to go back and look at what the driver 
ended up implementing.


Chris
��.n��������+%������w��{.n�����{��
b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f