On 8/30/17 9:17 AM, Thomas Petazzoni wrote:
So what Timur is saying perhaps is that mvebu_pinmux_gpio_request_enable() shouldn't be changing the type of muxing, and therefore shouldn't be calling mvebu_pinconf_group_set(). However, even the "reference" pinctrl-single.c implementation does it, in pcs_request_gpio(). Am I missing something ?
No, that's it. The question is, what exactly should the 'request' function do? Should it be modifying the hardware to satisfy the request? When I wrote my patch, I assumed that it wouldn't. I thought that request simply answered the question, "can I touch this GPIO"?
-- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
