On 08/07/2017 04:30 PM, Linus Walleij wrote:
of_irq_get() may return any negative error number as well as 0 on failure, while the driver only checks for -EPROBE_DEFER, blithely continuing with the call to gpiochip_set_chained_irqchip() -- that function expects the parent IRQ as *unsigned int*, so would probably do nothing when a large IRQ number resulting from a conversion of a negative error number is passed to it, however passing 0 would probably work but the driver won't receive valid GPIO bank interrupts. Check for 'ret <= 0' instead and return -ENXIO from the driver's probe iff of_irq_get() returned 0. Fixes: f9367793293d ("pinctrl: sirf: add sirf atlas7 pinctrl and gpio support") Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>Patch applied!Thanks! But to which branch? I'm not seeing it in linux-pinctrl.git...devel.Still not seeing the patch, perhaps you forgot to push?Nah just haven't had time to push yet...
Ah... seeing the patches now, thanks!
My mailbox is filling up with new patches at the same pace that I apply them it seems.
The joys of being a maintainer. :-)
Linus
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
