On Fri, Aug 4, 2017 at 12:00 AM, Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> wrote: > platform_get_irq() returns an error code, but the gpio-msic driver > ignores it and always returns -EINVAL. This is not correct, and > prevents -EPROBE_DEFER from being propagated properly. > > Notice that platform_get_irq() no longer returns 0 on error: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af > > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Mon, 7 Aug 2017 14:58:26 +0200
- In-reply-to: <20170803220001.GA7282@embeddedgus>
- References: <20170803220001.GA7282@embeddedgus>
- References:
- [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
- From: Gustavo A. R. Silva
- [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
- Prev by Date: Re: [PATCH v8 08/12] pinctrl: Add pinctrl driver for the RK805 PMIC
- Next by Date: Re: [PATCH] pinctrl: move const qualifier before struct
- Previous by thread: [PATCH] gpio: msic: fix error return code in platform_msic_gpio_probe()
- Next by thread: [PATCH] pinctrl: move const qualifier before struct
- Index(es):
 |