On Tue, Jul 25, 2017 at 3:41 PM, Dong Aisheng <aisheng.dong@xxxxxxx> wrote: > gpio_request_enable/disable_free actually are not quite necessary as > standard IMX pinctrl binding already sets GPIO mux from device tree, > e.g. VF610_PAD_PTB20__GPIO_42 or MX7D_PAD_SD2_CD_B__GPIO5_IO9 > No need to do it again in gpio_request_enable. > > And according to Stefan: > "For all GPIO I checked in upstream device trees we assign a pinctrl > to the same node, so in all cases gpio_request_enable/disable is really > unnecessary." > > So it should be safe to simply remove it. > > Note that this changes semantics for Vybrid, e.g. > "The two functions have been introduced for Vybrid (through > SHARE_MUX_CONF_REG) and mux pins as GPIOs automatically when a GPIO > gets requested. The automatic mux is optional by the pinmux/gpio > subsystem semantics, and other NXP devices do not use it, instead an > explicit pinctrl node is added in the device tree to mux GPIOs where > required. Hence this change aligns Vybrid to other NXP (i.MX) devices. > > Note that all upstream device tree assign proper pinctrl properties > where GPIOs are used so no change is necessary for device trees." > > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Alexandre Courbot <gnurou@xxxxxxxxx> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Cc: Fugang Duan <fugang.duan@xxxxxxx> > Cc: Bai Ping <ping.bai@xxxxxxx> > Acked-by: Stefan Agner <stefan@xxxxxxxx> > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html