Re: [PATCH 1/2] pinctrl: rockchip: Use common interface for recalced iomux

[Heiko Stuebner <heiko@xxxxxxxxx>]

Am Freitag, 21. Juli 2017, 14:27:14 CEST schrieb David Wu:
> The other Socs also need the feature of recalced iomux, so
> make it as a common interface like iomux route feature.
> 
> Signed-off-by: David Wu <david.wu@xxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/pinctrl-rockchip.c | 89 +++++++++++++++++++++-----------------
>  1 file changed, 50 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index e831647..fd4e491 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -76,7 +76,6 @@ enum rockchip_pinctrl_type {
>  #define IOMUX_SOURCE_PMU	BIT(2)
>  #define IOMUX_UNROUTED		BIT(3)
>  #define IOMUX_WIDTH_3BIT	BIT(4)
> -#define IOMUX_RECALCED		BIT(5)

very cool to see this flag go away and simply calculating the affected
bits is obviously a way nicer solution.

Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>

Thanks for that cleanup
Heiko

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html