On Tue, Jul 18, 2017 at 04:27:13PM +0530, Keerthy wrote: > Use the devm version of gpiochip_add_data and pass on the > return value. Reset the static variables to 0 before returning. You need to describe not just what you do, but also why you it. In this case, your fixing memory leaks and the gpio chip being left registered if this driver is unbound. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data
- From: Johan Hovold <johan@xxxxxxxxxx>
- Date: Wed, 19 Jul 2017 11:37:22 +0200
- In-reply-to: <1500375436-9435-2-git-send-email-j-keerthy@ti.com>
- References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-2-git-send-email-j-keerthy@ti.com>
- User-agent: Mutt/1.7.2 (2016-11-26)
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH] gpio: Convert to using %pOF instead of full_name
- Next by Date: Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data
- Previous by thread: Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data
- Next by thread: Re: [PATCH 1/4] gpio: davinci: Use devm_gpiochip_add_data in place of gpiochip_add_data
- Index(es):
 |