Re: [PATCH] pinctrl: baytrail: Do not call WARN_ON for a firmware bug

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Wed, 2017-07-12 at 14:44 +0200, Hans de Goede wrote:
> On 12-07-17 14:38, Andy Shevchenko wrote:
> > On Wed, 2017-07-12 at 14:31 +0200, Hans de Goede wrote:
> > > WARN_ON causes a backtrace to get logged which is only useful for
> > > kernel bugs. For signalling a firmware bug dev_warn(dev, FW_BUG
> > > "...")
> > > should be used.
> > > 
> > > This fixes users running userspace software to monitor kernel
> > > oopses
> > > getting a false positive bug-report every boot because of the
> > > wrong
> > > use of WARN_ON.
> > 
> > I'm not against the patch, looks good to me, though can you shed a
> > bit
> > of light what is the FW bug you are experiencing?
> 
> The bug is the code path which has the WARN_ON triggering, which means
> that the ACPI tables / or a driver want to use a pin as gpio and it
> has
> been setup differently (as a special function) by the firmware.

Yes, and what I'm asking are the details of it, what product, what
device needs that pin, and why do we think that is the rightful request
from the OS?

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html