On Friday 10 March 2017 09:56 PM, Thierry Reding wrote:
From: Thierry Reding <treding@xxxxxxxxxx>
Tegra186 has two GPIO controllers that are largely register compatible
between one another but are completely different from the controller
found on earlier generations.
Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
---
Changes in v2:
- add pin names to allow easy lookup using the chardev interface
- distinguish AON and main GPIO controllers by label
- use gpiochip_get_data() instead of container_of()
- use C99 initializers
Overall it looks fine to me.
Only thing I did not like is the of_xlate manipulation where the gpio
number is translated to another number for register access.
The reason is that it complicate in debugging when we instrument the
callbacks for some gpios and this is very common in our debugging.
I still request here to use simple mapping instead of complicating.
Otherwise:
Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
