Re: PATCH v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/03/2017 00:37, Robert Middleton wrote:
On Wed, Feb 22, 2017 at 10:34 AM,  <robert.middleton@xxxxxxxxxx> wrote:

This v2 patch changes the MCP23S08 interrupt logic to ensure that if multiple
inputs are changed at the same time, the kernel will be notified of all
the pins that changed.

I added several variables to the irq handler, however this means that there
are now quite a few local variables(possibly too many, as the kernel coding
standard says that more than 5-10 is probably too many:
https://www.kernel.org/doc/Documentation/process/coding-style.rst).  I'm
not sure what the best way to fix this is, or if it has to be fixed.

-Robert Middleton
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Hi, I would like to try and get some verification here on if this patch
is a good fix or not.  I have done testing on my side, and was
wondering if there was something else that I had to do in order to have
this patched upstream.

G'day Rob,

I was going to test it on my setup, just haven't got to it this week so far.
Probably Monday for me at this rate.

--
Regards
Phil Reid

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux