Re: Suspicious debounce handling code in pintctrl-baytrail

["mika.westerberg@xxxxxxxxxxxxxxx" <mika.westerberg@xxxxxxxxxxxxxxx>]

On Thu, Jan 26, 2017 at 02:15:21PM +0000, Shevchenko, Andriy wrote:
> On Thu, 2017-01-26 at 16:13 +0200, Andy Shevchenko wrote:
> > On Thu, 2017-01-26 at 15:00 +0100, Jean Delvare wrote:
> > > Hi Mika, hello Andy,
> > > 
> 
> > > Additionally, I suspect that in the "get" path, the following is
> > > > wrong:
> > > > 
> > > > 	case PIN_CONFIG_INPUT_DEBOUNCE:
> > > > 		if (!(conf & BYT_DEBOUNCE_EN))
> > > > 			return -EINVAL;
> > > > 
> > > > I'm not familiar with the pinctrl interface but my understanding
> > > > of
> > > > the PIN_CONFIG_INPUT_DEBOUNCE documentation is that the driver
> > > > must
> > > > return 0 if debouncing is disabled.
> > > 
> > > ?
> 
> No, this is correct.
> "...if it is available but disabled it should return -EINVAL"

OK, thanks Andy for checking it up.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html