Re: Suspicious debounce handling code in pintctrl-baytrail

["Shevchenko, Andriy" <andriy.shevchenko@xxxxxxxxx>]

On Thu, 2017-01-26 at 16:13 +0200, Andy Shevchenko wrote:
> On Thu, 2017-01-26 at 15:00 +0100, Jean Delvare wrote:
> > Hi Mika, hello Andy,
> > 

> > Additionally, I suspect that in the "get" path, the following is
> > > wrong:
> > > 
> > > 	case PIN_CONFIG_INPUT_DEBOUNCE:
> > > 		if (!(conf & BYT_DEBOUNCE_EN))
> > > 			return -EINVAL;
> > > 
> > > I'm not familiar with the pinctrl interface but my understanding
> > > of
> > > the PIN_CONFIG_INPUT_DEBOUNCE documentation is that the driver
> > > must
> > > return 0 if debouncing is disabled.
> > 
> > ?

No, this is correct.
"...if it is available but disabled it should return -EINVAL"

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo��.n��������+%������w��{.n�����{��
b���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f