On Sun, Sep 11, 2016 at 10:36 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > Macro regmap_update_bits can return a -ve on an error value so ret > needs to be an integer rather than a bool type. > > Fixes warning found by static analysis with cppcheck: > [drivers/pinctrl/aspeed/pinctrl-aspeed.c:192]: (warning) Comparison of > a boolean expression with an integer other than 0 or 1. > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> Dropping this but added your Reported-by to Arnds patch. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Tue, 13 Sep 2016 10:44:13 +0200
- In-reply-to: <20160911083625.7451-1-colin.king@canonical.com>
- References: <20160911083625.7451-1-colin.king@canonical.com>
- References:
- Prev by Date: Re: [PATCH -next] gpio: lp873x: Use devm_gpiochip_add_data() for gpio registration
- Next by Date: Re: [PATCH v2 3/4] ARM: dts: Add NextThing GR8 dtsi
- Previous by thread: Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits
- Next by thread: [PATCH v2 0/2] MIPS: TXx9: Move GPIO setup from .mem_setup() to .arch_init()
- Index(es):
 |