From: Colin Ian King <colin.king@xxxxxxxxxxxxx> Macro regmap_update_bits can return a -ve on an error value so ret needs to be an integer rather than a bool type. Fixes warning found by static analysis with cppcheck: [drivers/pinctrl/aspeed/pinctrl-aspeed.c:192]: (warning) Comparison of a boolean expression with an integer other than 0 or 1. Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index 7d461fc..75935ab 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -166,7 +166,7 @@ static bool aspeed_sig_expr_set(const struct aspeed_sig_expr *expr, bool enable, struct regmap *map) { int i; - bool ret; + int ret; ret = aspeed_sig_expr_eval(expr, enable, map); if (ret) -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html