Re: [PATCH V4 3/4] gpio: tegra: Get rid of all file scoped global variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 22, 2016 at 03:39:13PM +0530, Laxman Dewangan wrote:
[...]
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
[...]
>  static struct gpio_chip tegra_gpio_chip = {

This variable is still file-scoped. Why not get rid of it at the same
time? It's rather pointless to remove all file-scoped variables except a
single one, because now the driver still isn't properly equipped to deal
with multiple instances (however theoretical that may be).

Thierry

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux