On Mon, Apr 18, 2016 at 5:46 PM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote: > Remove the file static device handle variable as this is just > required for prints. The required handle can be stored in > tegra_gpio_chip and hence it become redundancy. Small but still worthy change. "dev" in the file's global namespace is scary and prone to conflict with local variables declarations. Acked-by: Alexandre Courbot <acourbot@xxxxxxxxxx> Now I hope you will take care of "regs" and the other static variables as Stephen rightfully suggested. :) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html