On 04/18/2016 11:00 AM, Laxman Dewangan wrote:
On Monday 18 April 2016 09:59 PM, Stephen Warren wrote:
On 04/18/2016 02:46 AM, Laxman Dewangan wrote:
Remove the file static device handle variable as this is just
required for prints. The required handle can be stored in
tegra_gpio_chip and hence it become redundancy.
This seems fine as far as it goes, but if it's worth doing this,
please move all the globals into the GPIO chip rather than just one of
the 7 globals.
the device pointer is part of the gpiochip and so it is better to use
gpiochip parent member instead of locally duplicating.
However, moving to other global variables needs some major changes and I
think it should be treated as independent of this patch.
This patch just utilizes the gpiochip.parent here.
Looking at the patch this just trades using one global (dev) for another
(tegra_gpio_chip), so when the other globals are removed, you'll need to
go back and change tegra_gpio_irq_set_type() again to remove use of the
global tegra_gpio_chip.
Still, this /does/ remove one global so I guess it's OK. I don't feel
terribly strongly, especially if you're going to send more patches soon
to remove the other globals. I'll leave the call to Linus.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
