Re: [PATCH v2] gpiolib: rewrite gpiodev_add_to_list

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Feb 26, 2016 at 9:37 PM, Bamvor Jian Zhang <bamv2005@xxxxxxxxx> wrote:

> From: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx>
>
> The original code of gpiodev_add_to_list is not very clear which
> lead to bugs or compiling warning, reference the following patches:
> Bugs:
> 1.  Commit ef7c7553039b ("gpiolib: improve overlap check of range of
>     gpio").
> 2.  Commit 96098df125c0 ("gpiolib: fix chip order in gpio list")
>
> Warning:
> 1.  Commit e28ecca6eac4 ("gpio: fix warning about iterator").
> of gpio").
>
> There is a off-list discussion about how to improve it consequently.
> This commit try to follow this by rewriting the whole functions.
>
> Tested pass with my gpio mockup driver and test scripts[1].
>
> [1] http://www.spinics.net/lists/linux-gpio/msg09598.html
>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx>

Patch applied. It surely looks much better like this!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html