Re: [PATCH] tools: gpio: add kernel headers in CFLAGS

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Fri, Feb 26, 2016 at 9:06 PM, Bamvor Jian Zhang <bamv2005@xxxxxxxxx> wrote:

> From: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx>
>
> Gpio tools require linux/gpio.h which may be only exist in kernel
> source code in a cross compile environment.
>
> Add such header to CFLAGS to avoid compiling failure.
>
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@xxxxxxxxxx>

I already got a patch like this and NACKed it: the procedure to compile
userspace tools is:

make -C ${LINUX_TREE} headers_install ARCH=<arch> INSTALL_HDR_PATH=<bar>
cd tools/gpio
make CFLAGS="${CFLAGS} -I<bar>"

So you push the new locations of your fresh kernel headers to the front of the
include path. But make headers_install is mandatory before trying to compile
userspace, as uapi may differ between architectures.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html