Re: [PATCH] gpio: create an API to detect open drain/source on lines

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, Feb 17, 2016 at 1:21 AM, Nicolas Saenz Julienne
<nicolassaenzj@xxxxxxxxx> wrote:
> On Tue, Feb 16, 2016 at 03:46:19PM +0100, Linus Walleij wrote:
>> My left hand merges code to privatize the descriptor handling
>> while my right hand merges drivers that poke around and
>> disrespect with the same gpiolib internals.
>>
>> So let's expose the proper APIs for drivers to ask the gpiolib
>> core if a line is marked as open drain or open source and
>> get some order around things so this driver compiles again.
>
> Thanks, looks way better now, I'd suggest to remove the "gpiolib.h"
> include since it's not needed anymore. I can do it's on a separate patch
> on top of this one if you prefer :)

I don't understand this comment? That is our internal library header
so that different files in gpiolib can share functions.

>
> Acked-by: Nicolas Saenz Julienne <nicolassaenzj@xxxxxxxxx>

Thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html