Re: [PATCH 47/54] mfd: htc-egpio: Be sure to clamp return value

[Lee Jones <lee.jones@xxxxxxxxxx>]

On Tue, 22 Dec 2015, Linus Walleij wrote:

> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
> 
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: Philipp Zabel <philipp.zabel@xxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> Lee: as mentioned in 00/54: either apply this directly
> or ACK it and I will take it into the GPIO tree.
> ---
>  drivers/mfd/htc-egpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/htc-egpio.c b/drivers/mfd/htc-egpio.c
> index d334e7d8a77d..c636b5f83cfb 100644
> --- a/drivers/mfd/htc-egpio.c
> +++ b/drivers/mfd/htc-egpio.c
> @@ -163,7 +163,7 @@ static int egpio_get(struct gpio_chip *chip, unsigned offset)
>  	value = egpio_readw(ei, reg);
>  	pr_debug("readw(%p + %x) = %x\n",
>  			ei->base_addr, reg << ei->bus_shift, value);
> -	return value & bit;
> +	return !!(value & bit);
>  }
>  
>  static int egpio_direction_input(struct gpio_chip *chip, unsigned offset)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html