Re: [PATCH 48/54] mfd: tc6393xb: Be sure to clamp return value

[Lee Jones <lee.jones@xxxxxxxxxx>]

On Tue, 22 Dec 2015, Linus Walleij wrote:

> As we want gpio_chip .get() calls to be able to return negative
> error codes and propagate to drivers, we need to go over all
> drivers and make sure their return values are clamped to [0,1].
> We do this by using the ret = !!(val) design pattern.
> 
> Cc: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> Lee: as mentioned in 00/54: either apply this directly
> or ACK it and I will take it into the GPIO tree.
> ---
>  drivers/mfd/tc6393xb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c
> index 8c84a513016b..1ecbfa40d1b3 100644
> --- a/drivers/mfd/tc6393xb.c
> +++ b/drivers/mfd/tc6393xb.c
> @@ -437,8 +437,8 @@ static int tc6393xb_gpio_get(struct gpio_chip *chip,
>  	struct tc6393xb *tc6393xb = container_of(chip, struct tc6393xb, gpio);
>  
>  	/* XXX: does dsr also represent inputs? */
> -	return tmio_ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8))
> -		& TC_GPIO_BIT(offset);
> +	return !!(tmio_ioread8(tc6393xb->scr + SCR_GPO_DSR(offset / 8))
> +		  & TC_GPIO_BIT(offset));
>  }
>  
>  static void __tc6393xb_gpio_set(struct gpio_chip *chip,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html