Re: [PATCH 05/18] dt-bindings: mfd: adp5585: document adp5589 I/O expander

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Thu, Mar 13, 2025 at 02:19:22PM +0000, Nuno Sá wrote:
>    reg:
>      maxItems: 1
> @@ -63,13 +70,26 @@ allOf:
>        properties:
>          gpio-reserved-ranges: false
>      else:
> -      properties:
> -        gpio-reserved-ranges:
> -          maxItems: 1
> -          items:
> +      if:

Do not nest if:then:else:if:then, it leads to code impossible to read.
Just provide if-then cases for each of your variant.




> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - adi,adp5585-00
> +                - adi,adp5585-02
> +                - adi,adp5585-03
> +                - adi,adp5585-04
> +      then:
> +        properties:
> +          gpio-reserved-ranges:
> +            maxItems: 1

one tem?

>              items:
> -              - const: 5
> -              - const: 1

But here two...

> +              items:
> +                - const: 5
> +                - const: 1

and this is confusing. I don't get what you want to express.

Best regards,
Krzysztof