Hi Artur, On Thu, Jan 30, 2025 at 6:10 PM Artur Weber <aweber.kernel@xxxxxxxxx> wrote: > Fixes two issues that were preventing GPIO from working correctly: > > - Lock/unlock functions tried to write the wrong bit to the unlock > registers for GPIOs with numbers larger than 32 > > - GPIOs only initialized as IRQs did not unlock the configuration > registers, causing IRQ-related configuration (e.g. setting the IRQ > type) to fail. > > Also includes a minor fix to add a missing newline to an error message. > > Tested on a Samsung Galaxy Grand Neo (baffinlite rev02) with a BCM23550 > (DTS not yet in mainline). > > Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx> Looks good to me, do you want to resend the patches picking up the Acks or do you want me to apply as-is? Should this go in as urgent fixes (-rcN) or as nonurgent? The DTS not being mainline suggests nonurgent but are there other systems suffering? Yours, Linus Walleij