Fixes two issues that were preventing GPIO from working correctly: - Lock/unlock functions tried to write the wrong bit to the unlock registers for GPIOs with numbers larger than 32 - GPIOs only initialized as IRQs did not unlock the configuration registers, causing IRQ-related configuration (e.g. setting the IRQ type) to fail. Also includes a minor fix to add a missing newline to an error message. Tested on a Samsung Galaxy Grand Neo (baffinlite rev02) with a BCM23550 (DTS not yet in mainline). Signed-off-by: Artur Weber <aweber.kernel@xxxxxxxxx> --- Artur Weber (3): gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0 gpio: bcm-kona: Make sure GPIO bits are unlocked when requesting IRQ gpio: bcm-kona: Add missing newline to dev_err format string drivers/gpio/gpio-bcm-kona.c | 73 ++++++++++++++++++++++++++++++++++++-------- 1 file changed, 60 insertions(+), 13 deletions(-) --- base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 change-id: 20250130-kona-gpio-fixes-6e74595e69f2 Best regards, -- Artur Weber <aweber.kernel@xxxxxxxxx>