Re: [PATCH] gpio: GPIO_GRGPIO should depend on OF_GPIO

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Oct 30, 2024 at 4:45 PM Andreas Larsson <andreas@xxxxxxxxxxx> wrote:
>
> On 2024-10-30 11:03, Geert Uytterhoeven wrote:
> > While the Aeroflex Gaisler GRGPIO driver has no build-time dependency on
> > gpiolib-of, it supports only DT-based configuration, and is used only on
> > DT systems.  Hence re-add the dependency on OF_GPIO, to prevent asking
> > the user about this driver when configuring a kernel without DT support.
> >
> > Fixes: bc40668def384256 ("gpio: grgpio: drop Kconfig dependency on OF_GPIO")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > ---
> >  drivers/gpio/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index 158ec0d7e52e2e51..a7b27a8541f572d5 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -341,6 +341,7 @@ config GPIO_GRANITERAPIDS
> >
> >  config GPIO_GRGPIO
> >       tristate "Aeroflex Gaisler GRGPIO support"
> > +     depends on OF_GPIO || COMPILE_TEST
> >       select GPIO_GENERIC
> >       select IRQ_DOMAIN
> >       help
>
> Or alternatively:
>
>         depends on OF || COMPILE_TEST
>
> Reviewed-by: Andreas Larsson <andreas@xxxxxxxxxxx>
>
> Thanks,
> Andreas
>

Yes, if anything it should depend on CONFIG_OF but is this really an
issue if this shows up as an option in Kconfig? It's not a hard no
from my side and I have heard a similar comment from Torvalds already
but I really don't get it: do people go through all the make config
prompts on a daily basis instead of using some base config and doing
make olddefconfig or menuconfig at worst?

Bartosz