Re: [PATCH] gpio: GPIO_GRGPIO should depend on OF_GPIO

[Andreas Larsson <andreas@xxxxxxxxxxx>]

On 2024-10-30 11:03, Geert Uytterhoeven wrote:
> While the Aeroflex Gaisler GRGPIO driver has no build-time dependency on
> gpiolib-of, it supports only DT-based configuration, and is used only on
> DT systems.  Hence re-add the dependency on OF_GPIO, to prevent asking
> the user about this driver when configuring a kernel without DT support.
> 
> Fixes: bc40668def384256 ("gpio: grgpio: drop Kconfig dependency on OF_GPIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 158ec0d7e52e2e51..a7b27a8541f572d5 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -341,6 +341,7 @@ config GPIO_GRANITERAPIDS
>  
>  config GPIO_GRGPIO
>  	tristate "Aeroflex Gaisler GRGPIO support"
> +	depends on OF_GPIO || COMPILE_TEST
>  	select GPIO_GENERIC
>  	select IRQ_DOMAIN
>  	help

Or alternatively:

	depends on OF || COMPILE_TEST

Reviewed-by: Andreas Larsson <andreas@xxxxxxxxxxx>

Thanks,
Andreas