Re: [PATCH v2] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format

[Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>]

Hi Krzysztof,
 
Thanks for your suggetions
 
>> +          corresponds to a physical pin on the GPIO expander.
>> +        items:
>> +          pattern: "^gpio([0-9]|[1][0-5])$"
>
>Since I expect resend, correct also quotes - use consistently either '
>or ".
 
Yes, I will change
 
>> +
>> +    i2c {
>
>Keep one complete example for i2c and one for spi. This was not in
>previous patch and change log does not explain why you need three
>examples.
 
Okay, I will drop one example of I2C
 
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        mcp23017: gpio@21 {
>
>Drop unused label
 
May I know how its unused, AFAIK, Since it's an I/O expanded, it’s referenced elsewhere, so keeping it is necessary for functionality.
 
Regards,
Himanshu
________________________________________
From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Sent: 26 October 2024 17:48
To: Himanshu Bhavani <himanshu.bhavani@xxxxxxxxxxxxxxxxx>
Cc: linus.walleij@xxxxxxxxxx <linus.walleij@xxxxxxxxxx>; robh@xxxxxxxxxx <robh@xxxxxxxxxx>; krzk+dt@xxxxxxxxxx <krzk+dt@xxxxxxxxxx>; Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx <linux-gpio@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx <devicetree@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format
 
CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

On Thu, Oct 24, 2024 at 06:16:18PM +0530, Himanshu Bhavani wrote:
> +  pinmux:
> +    type: object
> +    properties:
> +      pins:
> +        description:
> +          The list of GPIO pins controlled by this node. Each pin name
> +          corresponds to a physical pin on the GPIO expander.
> +        items:
> +          pattern: "^gpio([0-9]|[1][0-5])$"

Since I expect resend, correct also quotes - use consistently either '
or ".

> +        maxItems: 16
> +
> +      bias-pull-up:
> +        type: boolean
> +        description:
> +          Configures pull-up resistors for the GPIO pins. Absence of this
> +          property will leave the configuration in its default state.
> +
> +    required:
> +      - pins
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp23018: gpio@20 {
> +            compatible = "microchip,mcp23018";
> +            reg = <0x20>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> +            interrupt-controller;
> +            #interrupt-cells = <2>;
> +            microchip,irq-mirror;
> +        };
> +    };

Drop this example.

> +
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp23s17: gpio@0 {

Drop unused label

> +            compatible = "microchip,mcp23s17";
> +            reg = <0>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +            spi-max-frequency = <1000000>;
> +            microchip,spi-present-mask = /bits/ 8 <0x01>;
> +        };
> +    };
> +
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {

Keep one complete example for i2c and one for spi. This was not in
previous patch and changelog does not explain why you need three
examples.

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp23017: gpio@21 {

Drop unused label

Best regards,
Krzysztof