Re: [PATCH v2] dt-bindings: pinctrl: convert pinctrl-mcp23s08.txt to yaml format

[Krzysztof Kozlowski <krzk@xxxxxxxxxx>]

On Thu, Oct 24, 2024 at 06:16:18PM +0530, Himanshu Bhavani wrote:
> +  pinmux:
> +    type: object
> +    properties:
> +      pins:
> +        description:
> +          The list of GPIO pins controlled by this node. Each pin name
> +          corresponds to a physical pin on the GPIO expander.
> +        items:
> +          pattern: "^gpio([0-9]|[1][0-5])$"

Since I expect resend, correct also quotes - use consistently either '
or ".

> +        maxItems: 16
> +
> +      bias-pull-up:
> +        type: boolean
> +        description:
> +          Configures pull-up resistors for the GPIO pins. Absence of this
> +          property will leave the configuration in its default state.
> +
> +    required:
> +      - pins
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - gpio-controller
> +  - '#gpio-cells'
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp23018: gpio@20 {
> +            compatible = "microchip,mcp23018";
> +            reg = <0x20>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> +            interrupt-controller;
> +            #interrupt-cells = <2>;
> +            microchip,irq-mirror;
> +        };
> +    };

Drop this example.

> +
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp23s17: gpio@0 {

Drop unused label

> +            compatible = "microchip,mcp23s17";
> +            reg = <0>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +            spi-max-frequency = <1000000>;
> +            microchip,spi-present-mask = /bits/ 8 <0x01>;
> +        };
> +    };
> +
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    i2c {

Keep one complete example for i2c and one for spi. This was not in
previous patch and changelog does not explain why you need three
examples.

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mcp23017: gpio@21 {

Drop unused label

Best regards,
Krzysztof