Re: [RFC PATCH] pinctrl: pinmux: Introduce API to check if a pin is requested

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

Thank you for the review.

On Tue, Oct 15, 2024 at 10:43 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> thanks for your patch!
>
> On Tue, Oct 15, 2024 at 6:21 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
>
>
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Introduce `pin_requestesd` API to check if a pin is currently requested.
>
> What kind of function name is this?
>
> Do you mean
>
> pin_requested()?
>
Ouch, I will fix that.

> > This API allows pinctrl drivers to verify whether a pin is requested or
> > not by checking if the pin is owned by either `gpio_owner` or `mux_owner`.
>
> There is nothing wrong with the patch as such, but it needs to be
> illustrated by submitting it together with the first intended user
> and show how it is used, we don't add upfront APIs.
>
Sure, I will post the patches.

Cheers,
Prabhakar





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux