Hi Prabhakar, thanks for your patch! On Tue, Oct 15, 2024 at 6:21 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Introduce `pin_requestesd` API to check if a pin is currently requested. What kind of function name is this? Do you mean pin_requested()? > This API allows pinctrl drivers to verify whether a pin is requested or > not by checking if the pin is owned by either `gpio_owner` or `mux_owner`. There is nothing wrong with the patch as such, but it needs to be illustrated by submitting it together with the first intended user and show how it is used, we don't add upfront APIs. Yours, Linus Walleij