Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO

[Mary Strodl <mstrodl@xxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 01, 2024 at 09:04:58PM +0200, Bartosz Golaszewski wrote:
> I don't know much about the USB subsystem in the kernel, maybe Cc Greg
> KH on this?
Ok, I mostly just copied what I saw from other drivers.
 
> You could drop this label, all the gotos and the corresponding free in
> remove if you scheduled a devm action with devm_add_action_or_reset()
> right after getting the new index.
Thanks, didn't know about `devm_add_action_or_reset`! I was disappointed
to not find a `devm_ida_simple_get` when I wrote this, it is much cleaner
your way :)

> Overall it looks clean and nice but I can't tell if the USB-specific
> bits are correct.
> 
> Bart

Thanks for the review! I sent out a v4 that should hopefully address your feedback.

- Mary