Re: [PATCH v3] gpio: add support for FTDI's MPSSE as GPIO

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 26, 2024 at 2:44 PM Mary Strodl <mstrodl@xxxxxxxxxxx> wrote:

> FTDI FT2232H is a USB to GPIO chip. Sealevel produces some devices
> with this chip. FT2232H presents itself as a composite device with two
> interfaces (each is an "MPSSE"). Each MPSSE has two banks (high and low)
> of 8 GPIO each. I believe some MPSSE's have only one bank, but I don't
> know how to identify them (I don't have any for testing) and as a result
> are unsupported for the time being.
>
> Additionally, this driver provides software polling-based interrupts for
> edge detection. For the Sealevel device I have to test with, this works
> well because there is hardware debouncing. From talking to Sealevel's
> people, this is their preferred way to do edge detection.
>
> Signed-off-by: Mary Strodl <mstrodl@xxxxxxxxxxx>

All my review comments are addressed so with
Bartosz' nits addressed too:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij