Hi Andy, On Fri, Aug 23, 2024 at 3:17 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Fri, Aug 23, 2024 at 10:23 AM Geert Uytterhoeven > <geert@xxxxxxxxxxxxxx> wrote: > > On Fri, Aug 23, 2024 at 1:01 AM Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > of_node_to_fwnode() is a IRQ domain specific implementation of > > > of_fwnode_handle(). Replace the former with more suitable API. > > ... > > > > - girq->fwnode = of_node_to_fwnode(np); > > > + girq->fwnode = dev_fwnode(pctrl->dev); > > > > While this looks correct, the new call goes through many more hoops, and > > is not a simple inline function. [...] > P.S. Also note, it's _the only_ pin control driver that uses that API. Thanks for the explanation! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-pinctrl for v6.12. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds