Re: [PATCH v1 1/1] pinctrl: renesas: rzg2l: Replace of_node_to_fwnode() with more suitable API

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Andy,

On Fri, Aug 23, 2024 at 1:01 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> of_node_to_fwnode() is a IRQ domain specific implementation of
> of_fwnode_handle(). Replace the former with more suitable API.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Thanks for your patch!

> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -16,6 +16,7 @@
>  #include <linux/of.h>
>  #include <linux/of_irq.h>
>  #include <linux/platform_device.h>
> +#include <linux/property.h>
>  #include <linux/seq_file.h>
>  #include <linux/spinlock.h>
>
> @@ -2624,7 +2625,7 @@ static int rzg2l_gpio_register(struct rzg2l_pinctrl *pctrl)
>
>         girq = &chip->irq;
>         gpio_irq_chip_set_chip(girq, &rzg2l_gpio_irqchip);
> -       girq->fwnode = of_node_to_fwnode(np);
> +       girq->fwnode = dev_fwnode(pctrl->dev);

While this looks correct, the new call goes through many more hoops, and
is not a simple inline function.

Perhaps just &np->fwnode? ;-)

>         girq->parent_domain = parent_domain;
>         girq->child_to_parent_hwirq = rzg2l_gpio_child_to_parent_hwirq;
>         girq->populate_parent_alloc_arg = rzg2l_gpio_populate_parent_fwspec;

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds