Re: [PATCH 2/3] pinctrl: cy8c95x0: Use regmap ranges

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Aug 20, 2024 at 11:30 AM Patrick Rudolph
<patrick.rudolph@xxxxxxxxxxxxx> wrote:
> On Fri, Aug 9, 2024 at 2:13 PM Andy Shevchenko <andy@xxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, May 21, 2024 at 05:25:58PM +0200, Patrick Rudolph wrote:

...

> > Besides above, why virtual start is not well aligned? I would expect not
> > 0x31, but 0x40 or alike. It might explain some bugs with cache you have
> > seen.
> >
> I didn't find any rules on this, so I used the next free index.

I don't know either if any exists, but here is just my common sense.
When we have the offsets being aligned it's much easier to decypher and,
depending on implementation, may be more robust (in case there is some
bit arithmetics is being used, I hope not though). That's why the 0x40
or any aligned offset seems natural choice to me.

> > P.S. It might still be bugs in regmap core, if it is the case, they
> > need to be addressed.

-- 
With Best Regards,
Andy Shevchenko