Re: [PATCH 1/7] dt-bindings: pinctrl: Add support for Broadcom STB pin controller

["Ivan T. Ivanov" <iivanov@xxxxxxx>]

Hi,


On 08-01 16:19, Krzysztof Kozlowski wrote:
> 
> On 01/08/2024 10:38, Ivan T. Ivanov wrote:
> > Hi,
> > 
> > On 08-01 10:17, Krzysztof Kozlowski wrote:
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/pinctrl/brcm,brcmstb-pinctrl.yaml
> >>
> >> bcm2712 is Rpi, so not really STB. The name is confusing. Please use
> >> compatible as filename, so:
> >> brcm,bcm2712-pinctrl.yaml
> > 
> > According Florian it is:
> > 
> > https://lore.kernel.org/lkml/f6601f73-cb22-4ba3-88c5-241be8421fc3@xxxxxxxxxxxx/
> 
> OK, title can be like this, no problem, although then please expand what
> "STB" means.

Ok.

> 
> Bindings still are supposed to use compatible as filename.
> 

IIUC, you suggest to rename compatible string from brcm,bcm2712-pinctrl
to brcm,brcmstb-pinctrl?!

Regards,
Ivan