Re: [PATCH/RFC 0/4] pinctrl: sh-pfc: Add PINMUX_SINGLE()

[Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>]

Hi Geert,

Thank you for the patches.

On Tuesday 20 October 2015 21:26:31 Geert Uytterhoeven wrote:
> 	Hi,
> 
> Currently single-function pins are described using the raw PINMUX_DATA()
> macro.
> 
> Morimoto-san doesn't like that. He proposed to use the existing
> PINMUX_IPSR_NOGP() macro instead (cfr. "[RFC] pinctrl: sh-pfc: r8a7795:
> Add pinmux data for single-function pins",
> http://www.spinics.net/lists/linux-sh/msg44823.html).
> However, that macro is intended to describe a pinmux configuration
> without GPIO function, which feels wrong to me.
> 
> This patch series proposes an alternative, introducing a new macro
> PINMUX_SINGLE() to describe a pinmux configuration for a single-function
> pin. It also converts the existing single-function pin descriptions.
> 
> Thanks for your comments!

For patches 2-4,

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

But why haven't you included the other SoCs ?

> Geert Uytterhoeven (4):
>   pinctrl: sh-pfc: Add PINMUX_SINGLE()
>   pinctrl: sh-pfc: r8a7790: Use PINMUX_SINGLE() instead of raw
>     PINMUX_DATA()
>   pinctrl: sh-pfc: r8a7791: Use PINMUX_SINGLE() instead of raw
>     PINMUX_DATA()
>   pinctrl: sh-pfc: r8a7794: Use PINMUX_SINGLE() instead of raw
>     PINMUX_DATA()
> 
>  drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 18 +++++++--------
>  drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 34 ++++++++++++++--------------
>  drivers/pinctrl/sh-pfc/pfc-r8a7794.c | 44 +++++++++++++++++----------------
>  drivers/pinctrl/sh-pfc/sh_pfc.h      |  7 ++++++
>  4 files changed, 55 insertions(+), 48 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html