Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if not set

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Jul 16, 2015 at 1:22 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Thu, Jun 25, 2015 at 7:30 PM, Grygorii Strashko
> <grygorii.strashko@xxxxxx> wrote:
>
>> Assign GPIO chip owner field to chip->dev->driver->owner if it was not
>> configured by GPIO driver.
>>
>> Cc: Johan Hovold <johan@xxxxxxxxxx>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
>
> Patch applied with Alex' review tag.
>
>>  There is also one positive additional side effect:
>>  lines like below can be removed from a lot of GPIO
>>  drivers
>>         rdc321x_gpio_dev->chip.owner = THIS_MODULE;
>
> Yes let's do this :)

Or actually, I have had some second thought to why gpio_chip
is duplicating struct members from struct device at all.

Why should it even have "owner" and "of_node"?

Should we not just rewrite this code to follow the struct device *dev
pointer in gpio_chip and use "owner" and "of_node" from there?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html