Re: [PATCH][RFC] gpiolib: rename gpiod_set_array to gpiod_set_array_value

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Wed, May 13, 2015 at 11:04 AM, Rojhalat Ibrahim <imr@xxxxxxxxxxx> wrote:

> There have been concerns that the function names gpiod_set_array() and
> gpiod_get_array() might be confusing to users. One might expect
> gpiod_get_array() to return array values, while it is actually the array
> counterpart of gpiod_get(). To be consistent with the single descriptor API
> we could rename gpiod_set_array() to gpiod_set_array_value(). This makes
> some function names a bit lengthy: gpiod_set_raw_array_value_cansleep().
>
> Signed-off-by: Rojhalat Ibrahim <imr@xxxxxxxxxxx>

OK patch applied...

>  drivers/gpio/gpiolib.c                 |   54 +++++++++++++++++----------------
>  drivers/net/phy/mdio-mux-gpio.c        |    3 +

You should ideally have David's ACK for this.

>  drivers/tty/serial/serial_mctrl_gpio.c |    2 -

And Greg's ACK for this.

I hope this doesn't wreak havoc or I will have to revert it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html