Re: [PATCH v5 09/11] ARM: imx: add imx7d clk tree support

[Rob Herring <robherring2@xxxxxxxxx>]

On Tue, Apr 21, 2015 at 3:39 PM, Zhi Li <lznuaa@xxxxxxxxx> wrote:
> On Tue, Apr 21, 2015 at 3:30 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
>> On Tue, Apr 21, 2015 at 9:53 AM,  <Frank.Li@xxxxxxxxxxxxx> wrote:
>>> From: Frank Li <Frank.Li@xxxxxxxxxxxxx>
>>>
>>> Add i.MX7D clk tree support.
>>>
>>> Enable all clock to bring up imx7.
>>> Clock framework need be modified a little since imx7d
>>> change clock design. otherwise system will halt and block the
>>> other part upstream.
>>>
>>> All clock refine need wait for Dong Aisheng's patch
>>> clk: support clocks which requires parent clock on during operation
>>> Or other solution ready.
>>>
>>> Signed-off-by: Anson Huang <b20788@xxxxxxxxxxxxx>
>>> Signed-off-by: Adrian Alonso <aalonso@xxxxxxxxxxxxx>
>>> Signed-off-by: Frank Li <Frank.Li@xxxxxxxxxxxxx>
>>> ---
>>>  arch/arm/mach-imx/clk-imx7d.c | 887 ++++++++++++++++++++++++++++++++++++++++++
>>>  arch/arm/mach-imx/clk-pllv3.c |  16 +-
>>>  arch/arm/mach-imx/clk.h       |   9 +
>>>  3 files changed, 911 insertions(+), 1 deletion(-)
>>>  create mode 100644 arch/arm/mach-imx/clk-imx7d.c
>>
>> Why is i.MX clock code not moved to drivers/clk?
>
> Guo Shawn:
>         what's plan clock code move to driver/clk?
>
> Rob:
>        It is not related i.mx7 bring up.
>        There are many upstream work depend on this.
>        we can work on code movement after that.
>        Are you okay?

If it was going in my tree, no. But it is not, so it is not my call.
However, I would not let you continue to add stuff if you have not
done the clean-up that has been done for almost every other modern
platform.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html