Re: [PATCH] pinctrl: dt-binding: fix generic pinmux/pinconf examples

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

On Wed, Mar 18, 2015 at 01:16:00PM +0100, Linus Walleij wrote:
> On Sun, Mar 15, 2015 at 7:55 AM, Baruch Siach <baruch@xxxxxxxxxx> wrote:
> > pinconf_generic_dt_node_to_map() scans only subnodes of the pinctrl-0 
> > pahndle, not the referenced node itself. Change the example nodes to 
> > match.
> >
> > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>
> 
> Patch applied...
> 
> >  state_0_node_a {
> > -       function = "uart0";
> > -       groups = "u0rxtx", "u0rtscts";
> > +       uart0 {
> > +               function = "uart0";
> > +               groups = "u0rxtx", "u0rtscts";
> > +       };
> >  };
> >  state_1_node_a {
> > -       function = "spi0";
> > -       groups = "spi0pins";
> > +       spi0 {
> > +               function = "spi0";
> > +               groups = "spi0pins";
> > +       };
> >  };
> 
> But that is a bit insane. We should fix the parsing code to handle
> either case instead.

OK. I'll take a look into this tomorrow.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux