Re: [PATCH] gpio-rcar: .irq_set_wake() support to work with suspend_device_irqs()

[Magnus Damm <magnus.damm@xxxxxxxxx>]

Hi Linus, Kaneko-san,

On Fri, Nov 14, 2014 at 6:53 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Fri, Nov 7, 2014 at 10:22 AM, Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> wrote:
>
>> From: Shinya Kuribayashi <shinya.kuribayashi.px@xxxxxxxxxxx>
>>
>> All IRQs in the kernel get disabled by PM core prior to .suspend_noirq()
>> step through kernel/irq/pm.c::suspend_device_irqs().
>>
>> The SYSC hardware block in the R-Car SoCs, on the other hand, uses any
>> interrupt as wake-up source(es) and requires them to be unmasked during
>> the system is suspended.
>>
>> This patch implements .irq_set_wake() which makes __disable_irq() call
>> a NOP when a GPIO port is claimed as a wake-up source.
>>
>> Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi.px@xxxxxxxxxxx>
>> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx>
>
> Patch tentatively applied unless Magnus or Laurent starts complaining...

I'll bite. =)

Thanks for the efforts, but I doubt that this patch is needed. Unless
I'm mistaken this feature is implemented already in the following
commits:

4039611 gpio: rcar: Enable mask on suspend
fba968a gpio: rcar: Use lazy disable

> This driver should be simple to convert to GPIOLIB_IRQCHIP and get
> rid of some code overhead.

Perhaps Geert [CC:ed] can have a look at this in the not so distant future?

Thanks,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html